Skip to content

Make heartbeat interval configurable #4925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danizord opened this issue Apr 12, 2022 · 4 comments · Fixed by #5867
Closed

Make heartbeat interval configurable #4925

danizord opened this issue Apr 12, 2022 · 4 comments · Fixed by #5867

Comments

@danizord
Copy link

Problem Statement

I have a pageload transaction that normally should take 30s+ to finish, but IdleTransaction's heartbeat is finishing the transaction before the page content is fully loaded.

Solution Brainstorm

Make heartbeat interval configurable

@lforst
Copy link
Contributor

lforst commented Apr 13, 2022

I believe this is already possible by using the idleTimeout option of the BrowserTracing integration. You can read more about it here: https://docs.sentry.io/platforms/javascript/performance/instrumentation/automatic-instrumentation/#idletimeout

Let me know if this fits your case!

@danizord
Copy link
Author

I believe this is already possible by using the idleTimeout option of the BrowserTracing integration. You can read more about it here: https://docs.sentry.io/platforms/javascript/performance/instrumentation/automatic-instrumentation/#idletimeout

Let me know if this fits your case!

Unfortunately not. Even if I configure 60s as idleTimeout, after 15s (3 heartbeats) with the same activity count, it finishes the transaction.

@lforst
Copy link
Contributor

lforst commented Apr 13, 2022

Ah yeah you are right. The amount of heartbeats and their intervals are currently hardcoded. I'll backlog this and take it to the team. Thanks for writing in!

By the way, feel free to open a PR! :) We'll look over it and assist in writing tests and documentation.

@danizord
Copy link
Author

Nice! Added to my backlog as well :D Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants