Node MySQL2 Integration

[derekrprice]

An integration is available from @sentry/tracing for the node mysql module but not mysql2. The module APIs are nearly identical and I would hope this would be easy to enable.

[jdrydn]

Yeah, I'd be interested in this too. I'd be happy to implement it if there's a rough guide somewhere to building these sorts of tracing integrations?

Looking at the source code, it's heavily dependant on loading a specific file & then monkey-patching a method?

sentry-javascript/packages/tracing/src/integrations/mysql.ts

Line 25 in c0089b5

const pkg = loadModule<MysqlConnection>('mysql/lib/Connection.js');

[kamilogorek]

Looking at the source code, it's heavily dependant on loading a specific file & then monkey-patching a method?

That's exactly how it works. We need however, work on extracting all these into a separate packages, as loading them for everyone is not optimal right now.

[jpike88]

@kamilogorek the file is tiny and the different between mysql/mysql2 is almost none, they both have a connection.js with the only difference being that mysql2 is passing an additional config parameter,

See pr #3661

[jdrydn]

@jpike88 Nice! That mysql2.ts file in your PR is literally what I've done to add support to my Sentry instance, so far working really well!

[github-actions]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[derekrprice]

I, for one, would still be excited to see this. Looks like that PR just got closed without merging. What happened?

[RedSpid3r]

+1 for support on this as i use mysql2