feat(core): Include component name annotation plugin with all bundler plugins except esbuild #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Still need to do some finishing work on this PR but opening it early to get some eyes on it due to the timezone difference in VIE. In the morning, I will update the documentation in the README to include these changes |
lforst
approved these changes
Feb 1, 2024
lforst
left a comment
lforst
left a comment
There was a problem hiding this comment.
Generally looks good! 👍 I left some comments that should be adressed.
Please also add documentation for the option to generate-documentation-table.ts so that the readmes on npm have the the option. It would be extra cool if you could somehow manage to exclude the added option from the docs (and also the types) for esbuild.
Contributor
Author
|
@lforst Addressed all your comments and added conditional generation of options in the docs based on the bundler type 😄 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking up this PR into a smaller chunk: #464
This PR focuses on bringing in the new plugin introduced in #468, and adding it to all bundlers as an optional feature. It is not currently supported by esbuild, so there are guardrails preventing its use in the esbuild bundler plugins.