fix(esbuild): Inject different debug IDs into different output bundles #301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #300
Esbuild will generate one output bundle for each entrypoint that is defined. The issue previously was that we were injecting an import that is only resolved and loaded once for all entrypoints, leading to the same debug ID in all output bundles.
We attempt fixing this by transforming the entrypoints via a proxy module that in return imports a stub that injects the debug ID snippets into the entrypoints.
One thing I am still a little bit unsure about is why just adding a namespace to the existingonResolveandonLoaddidn't work, since that is basically what we're doing here, minus the proxy module. It fails because it can't the injected file anymore. Maybe this is some intransparent behaviour of esbuild.It seems esbuild does not call
onResolveforinjected modules.