Skip to content

Conversation

@lforst
Copy link

@lforst lforst commented May 26, 2023

@lforst lforst requested review from Lms24 and mydea and removed request for Lms24 May 30, 2023 07:58
@lforst lforst self-assigned this May 31, 2023
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a fix? Since this is technically breaking for those who have --strict-peer-deps set.

@lforst
Copy link
Author

lforst commented Jun 5, 2023

Shouldn't this be a fix? Since this is technically breaking for those who have --strict-peer-deps set.

Ah true, good point. Thanks!

@lforst lforst changed the title meta: Set minimum webpack 4 peer dep to 4.40.0 fix: Set minimum webpack 4 peer dep to 4.40.0 Jun 5, 2023
@lforst lforst changed the title fix: Set minimum webpack 4 peer dep to 4.40.0 fix(webpack): Set minimum webpack 4 peer dep to 4.40.0 Jun 5, 2023
@lforst lforst merged commit 015d8fb into main Jun 5, 2023
@lforst lforst deleted the lforst-set-minimum-webpack-4-peer-de branch June 5, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants