feat: Auto detect build artifacts #257
Conversation
| debugIdChunkFilePath.endsWith(".cjs") | ||
| ); | ||
|
|
||
| if (Array.isArray(assets) && assets.length === 0) { |
There was a problem hiding this comment.
Is assets always normalized to an array? otherwise, what about assets: ""?
There was a problem hiding this comment.
My thought process here was to just skip uploading entirely when users provide an empty array (as a means of disabling I guess). An empty string is more or less user error which we don't care to catch here. I think this will be implicitly caught by the glob pattern not finding anything and the message below then saying "check your assets option".
There was a problem hiding this comment.
Oh good point. At the time of writing I thought for some reason an empty array and an empty string the same semantic implications here but you're right, an empty string looks more like an error than an empty array.
| debugIdChunkFilePath.endsWith(".cjs") | ||
| ); | ||
| const debugIdChunkFilePaths = ( | ||
| await glob(assets ?? buildArtifactPaths, { |
There was a problem hiding this comment.
Can we add a log that we're using the auto-determined paths if we fall back to buildArtifactPaths?
Will auto detect build artifacts based on the information bundlers provide in the build end hooks - making the
assetsoption optional.Risky change incoming.