fix(core): Account for undefined release name values #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 19, 2023 14:46
Lms24
approved these changes
May 22, 2023
| useArtifactBundle: true, | ||
| }); | ||
| await cliInstance.releases.uploadSourceMaps( | ||
| releaseName ?? "undefined", // unfortunetly this needs a value for now but it will not matter since debug IDs overpower releases anyhow |
Member
There was a problem hiding this comment.
Are we/CLI team going to fix this on the CLI side ?
Author
There was a problem hiding this comment.
Yeah I think we should. Unfortunately, it will make the interface of Sentry CLI even more complicated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where Sentry CLI throws if we only pass an empty string as a release value for debug ID upload.