feat(esbuild): Add debug ID injection for esbuild #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
AbhiPrasad
reviewed
Apr 13, 2023
| if (unpluginMetaContext.framework === "esbuild") { | ||
| if (internalOptions._experiments.debugIdUpload) { | ||
| plugins.push({ | ||
| name: "sentry-debug-id-plugin", |
There was a problem hiding this comment.
shouldn't we specifically highlight this is esbuild only?
Or we can also move the rest of the debug id logic into this plugin.
There was a problem hiding this comment.
shouldn't we specifically highlight this is esbuild only?
I don't think it is necessary to say it is explicitly for esbuild, since it will only be used in esbuild anyways, but this is such a little change I will just do it :p
Or we can also move the rest of the debug id logic into this plugin.
Unfortunately, this is a bit of a limitation/bug with unplugin itself. You cannot define hooks + a config field in the same plugin, so we need to emit two. If you define hooks + config, the hooks will not run.
AbhiPrasad
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.