Add OTEL propagator #2380
Add OTEL propagator #2380
Conversation
… spanId for Sentry instead of creating a new one
adinauer
requested review from
markushi,
romtsn and
stefanosiano
as code owners
|
Performance metrics 🚀
|
| new SentryTraceHeader(sentryTraceHeader), | ||
| baggage); | ||
| baggage, | ||
| null); |
There was a problem hiding this comment.
shouldn't this be covered by the method overload without spanId?
There was a problem hiding this comment.
I added another param (spanId) to it. The other overload doesn't have baggage so can't be used here. I didn't want to introduce yet another overload for something that's only used internally anyways. Eventually I'd like to improve this by e.g. introducing a param object that has defaults which can be overriden.
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
I think we might need some more tests, but I'm happy with where this is for now for an alpha!
Let's 
Yes, indeed. It hurts a little to have not tests yet 😢 . Was already on my list of next things to do. Added it as explicit item to #2327 now. |
#skip-changelog
📜 Description
Add
SentryPropagator, register it and use it by default in the Sentry Java Agent JAR.💡 Motivation and Context
Continue traces (via
sentry-traceandbaggageheaders) by extracting headers from incoming requests and using that info for Span/Transaction creating as well as injecting headers into outgoing requests.💚 How did you test it?
Manually
📝 Checklist
🔮 Next steps