Document new configuration option #9526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@soerface is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vivianyentran
approved these changes
Mar 21, 2024
docs/platforms/javascript/common/user-feedback/configuration/index.mdx
Outdated
Show resolved
Hide resolved
billyvg
approved these changes
Mar 21, 2024
The configuration option was added in getsentry/sentry-javascript#11153. Co-authored-by: vivianyentran <[email protected]>
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
The feature has been released in 7.109.0: https://github.com/getsentry/sentry-javascript/releases/tag/7.109.0 Therefore, I think that the documentation change is ready to be merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-merge checklist
Description of changes
This is documenting a new configuration option I proposed here: getsentry/sentry-javascript#11153
The PR in the js SDK repository is currently reviewed by @billyvg. Therefore, I'm leaving this note here so we don't forget to update the docs as soon as the feature is merged and released with the next SDK version.
HINT: The documentation is also featuring this image: https://docs.sentry.io/platforms/javascript/common/user-feedback/configuration/user-feedback-widget-customization.png
Maybe we should get a sentry graphics designer involved to update the image, indicating that now also the "(required)" text is configurable.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.