Skip to content

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Jul 19, 2021

Fixes #3870

@vercel
Copy link

vercel bot commented Jul 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/DpSUHQgrXeCbMqqDy1PWjAvsjuzw
✅ Preview: https://sentry-docs-git-dedupe-docs.sentry.dev

Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One structural question, but otherwise LGTM!

@@ -148,3 +148,12 @@ Sentry.init({
},
});
```


### Dedupe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've added this at the very end of the page, but that puts it under "Modifying System Integrations" rather than in the list of default integrations. Not sure if you intended this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Fixed and merging now

@HazAT HazAT enabled auto-merge (squash) July 21, 2021 08:14
@HazAT HazAT merged commit 5e14d76 into master Jul 21, 2021
@HazAT HazAT deleted the dedupe-docs branch July 21, 2021 08:17
taylangocmen pushed a commit that referenced this pull request Jul 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DedupeIntegration is now a default integration
3 participants