-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update dedupe docs #3902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dedupe docs #3902
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/sentry-docs/DpSUHQgrXeCbMqqDy1PWjAvsjuzw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One structural question, but otherwise LGTM!
src/platforms/javascript/common/configuration/integrations/default.mdx
Outdated
Show resolved
Hide resolved
@@ -148,3 +148,12 @@ Sentry.init({ | |||
}, | |||
}); | |||
``` | |||
|
|||
|
|||
### Dedupe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've added this at the very end of the page, but that puts it under "Modifying System Integrations" rather than in the list of default integrations. Not sure if you intended this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Fixed and merging now
src/platforms/javascript/common/configuration/integrations/default.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Fixes #3870