Skip to content

Explicit Scope for JS SDKs #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 5, 2020
Merged

Explicit Scope for JS SDKs #1731

merged 5 commits into from
Jun 5, 2020

Conversation

kamilogorek
Copy link
Contributor

@HazAT HazAT requested a review from PeloWriter June 4, 2020 10:15
HazAT
HazAT requested changes Jun 4, 2020
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM 👍

@kamilogorek kamilogorek requested a review from HazAT June 4, 2020 10:30
AbhiPrasad
AbhiPrasad reviewed Jun 4, 2020
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions/comments, will defer final review to the docs extraordinaires

kamilogorek
kamilogorek commented Jun 4, 2020
View reviewed changes
PeloWriter
PeloWriter approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@PeloWriter PeloWriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@kamilogorek
Copy link
Contributor Author

Fixed all review comments. Thanks!

@kamilogorek kamilogorek merged commit 08fd29c into master Jun 5, 2020
@kamilogorek kamilogorek deleted the js-explicit-scope branch June 5, 2020 12:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad left review comments

@HazAT HazAT HazAT approved these changes

@MimiDumpling MimiDumpling Awaiting requested review from MimiDumpling

+1 more reviewer

@PeloWriter PeloWriter PeloWriter approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kamilogorek @HazAT @AbhiPrasad @PeloWriter