Skip to content

Conversation

@JoshuaMoelans
Copy link
Member

@JoshuaMoelans JoshuaMoelans commented Sep 29, 2025

DESCRIBE YOUR PR

Cleans up some small mistakes/inaccuracies/typos in the native docs

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Note

Tightens Native docs accuracy, updates API examples (boolean usage and sampler signature), adjusts logs minimum version, and cleans formatting.

  • Native docs:
    • Options: Clarify release sourcing (remove browser-specific note); update before-send to return sentry_value_new_null(); link enable-logs to /platforms/native/logs.
    • Logs: Lower minimum supported SDK to 0.11.1; update C examples to use 1 instead of true.
    • Performance/Tracing: Update traces_sampler_callback signature to include void *user_data in examples.
    • Breadcrumbs: Tweak documented keys list (simplify timestamp note).
    • Signal handling: Minor formatting/whitespace fixes and remove stray code fence; tidy SIGXFSZ bullet.

Written by Cursor Bugbot for commit be80c5b. This will update automatically on new commits. Configure here.

@vercel
Copy link

vercel bot commented Sep 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Oct 1, 2025 0:03am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Oct 1, 2025 0:03am

@codecov
Copy link

codecov bot commented Sep 29, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.13MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.9MB -9 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js 6.46kB 7.46kB 645.5% ⚠️
server/middleware-*.js -6.46kB 1.0kB -86.59%
static/KeU7HPNzRJ7FkfBjohOKm/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/KeU7HPNzRJ7FkfBjohOKm/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/XUW-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/XUW-*.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️

@JoshuaMoelans JoshuaMoelans force-pushed the joshua/chore/native-logs-fixup branch from be80c5b to 211a362 Compare October 1, 2025 11:30
Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, sooo much to correct. Thx @JoshuaMoelans!

@JoshuaMoelans JoshuaMoelans enabled auto-merge (squash) October 1, 2025 11:54
@JoshuaMoelans JoshuaMoelans merged commit 38382a6 into master Oct 1, 2025
13 checks passed
@JoshuaMoelans JoshuaMoelans deleted the joshua/chore/native-logs-fixup branch October 1, 2025 12:03
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants