Skip to content

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Mar 31, 2025

📜 Description

  • Add FeatureFlagIntegration

💡 Motivation and Context

Closes #2747

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

Copy link
Contributor

github-actions bot commented Mar 31, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4f247a5

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 93.15068% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.78%. Comparing base (4c72876) to head (4f247a5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dart/lib/src/protocol/sentry_feature_flag.dart 89.47% 2 Missing ⚠️
dart/lib/src/sentry.dart 75.00% 2 Missing ⚠️
dart/lib/src/protocol/sentry_feature_flags.dart 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2825      +/-   ##
==========================================
+ Coverage   87.69%   87.78%   +0.08%     
==========================================
  Files         266      269       +3     
  Lines        8897     8970      +73     
==========================================
+ Hits         7802     7874      +72     
- Misses       1095     1096       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Mar 31, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 449.85 ms 508.61 ms 58.76 ms
Size 6.44 MiB 7.43 MiB 1007.37 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
03e4c9b 410.34 ms 493.20 ms 82.86 ms
0a82a1e 321.02 ms 393.82 ms 72.80 ms
6fedcab 388.26 ms 487.42 ms 99.16 ms
803f3a9 424.66 ms 505.24 ms 80.58 ms
ffae3e3 360.67 ms 466.24 ms 105.57 ms
bf4aed7 311.24 ms 365.66 ms 54.42 ms
ddc97ad 331.45 ms 384.06 ms 52.61 ms
d53c6fa 282.83 ms 344.00 ms 61.17 ms
f922f8f 332.31 ms 374.67 ms 42.37 ms
547db82 453.40 ms 482.88 ms 29.48 ms

App size

Revision Plain With Sentry Diff
03e4c9b 6.35 MiB 7.42 MiB 1.07 MiB
0a82a1e 6.15 MiB 7.11 MiB 981.82 KiB
6fedcab 6.33 MiB 7.30 MiB 987.83 KiB
803f3a9 6.46 MiB 7.48 MiB 1.02 MiB
ffae3e3 6.26 MiB 7.20 MiB 958.78 KiB
bf4aed7 6.06 MiB 7.03 MiB 997.04 KiB
ddc97ad 6.16 MiB 7.14 MiB 1003.75 KiB
d53c6fa 6.16 MiB 7.14 MiB 1011.18 KiB
f922f8f 5.94 MiB 6.95 MiB 1.01 MiB
547db82 6.49 MiB 7.56 MiB 1.07 MiB

Previous results on branch: feat/feature-flags-integration

Startup times

Revision Plain With Sentry Diff
16ee1e6 468.83 ms 594.78 ms 125.95 ms
1559285 435.55 ms 458.16 ms 22.61 ms

App size

Revision Plain With Sentry Diff
16ee1e6 6.44 MiB 7.57 MiB 1.13 MiB
1559285 6.44 MiB 7.57 MiB 1.13 MiB

@denrase denrase marked this pull request as ready for review March 31, 2025 14:23
Copy link
Contributor

github-actions bot commented Mar 31, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1259.27 ms 1269.79 ms 10.52 ms
Size 8.43 MiB 9.99 MiB 1.56 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d089990 1206.19 ms 1233.08 ms 26.89 ms
6aab859 1245.14 ms 1247.59 ms 2.45 ms
dd5521e 1254.28 ms 1263.37 ms 9.09 ms
07cd9e8 1237.04 ms 1257.50 ms 20.46 ms
21845e2 1279.37 ms 1298.81 ms 19.45 ms
a7acb24 1296.71 ms 1317.69 ms 20.98 ms
e4d5aa8 1224.15 ms 1245.72 ms 21.57 ms
a61674e 1275.51 ms 1290.81 ms 15.30 ms
6034b0a 1244.89 ms 1270.22 ms 25.33 ms
73d70bf 1249.08 ms 1268.41 ms 19.33 ms

App size

Revision Plain With Sentry Diff
d089990 8.33 MiB 9.40 MiB 1.07 MiB
6aab859 8.29 MiB 9.36 MiB 1.07 MiB
dd5521e 8.43 MiB 9.97 MiB 1.54 MiB
07cd9e8 8.38 MiB 9.77 MiB 1.40 MiB
21845e2 8.15 MiB 9.12 MiB 991.34 KiB
a7acb24 8.16 MiB 9.17 MiB 1.01 MiB
e4d5aa8 8.33 MiB 9.62 MiB 1.29 MiB
a61674e 8.10 MiB 9.16 MiB 1.07 MiB
6034b0a 8.33 MiB 9.40 MiB 1.07 MiB
73d70bf 8.38 MiB 9.70 MiB 1.33 MiB

Previous results on branch: feat/feature-flags-integration

Startup times

Revision Plain With Sentry Diff
16ee1e6 1257.78 ms 1278.57 ms 20.80 ms
1559285 1247.53 ms 1261.86 ms 14.33 ms

App size

Revision Plain With Sentry Diff
16ee1e6 8.43 MiB 9.99 MiB 1.56 MiB
1559285 8.43 MiB 9.99 MiB 1.56 MiB

Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! that was a quick 🚀

@denrase denrase requested a review from buenaflor April 2, 2025 08:57
Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge the mutable data PR then update this

Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@denrase denrase merged commit 0aa80ac into main Apr 7, 2025
150 of 154 checks passed
@denrase denrase deleted the feat/feature-flags-integration branch April 7, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flutter] Feature Flags Reporting - API
2 participants