-
-
Notifications
You must be signed in to change notification settings - Fork 272
Add FeatureFlagIntegration
#2825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2825 +/- ##
==========================================
+ Coverage 87.69% 87.78% +0.08%
==========================================
Files 266 269 +3
Lines 8897 8970 +73
==========================================
+ Hits 7802 7874 +72
- Misses 1095 1096 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
03e4c9b | 410.34 ms | 493.20 ms | 82.86 ms |
0a82a1e | 321.02 ms | 393.82 ms | 72.80 ms |
6fedcab | 388.26 ms | 487.42 ms | 99.16 ms |
803f3a9 | 424.66 ms | 505.24 ms | 80.58 ms |
ffae3e3 | 360.67 ms | 466.24 ms | 105.57 ms |
bf4aed7 | 311.24 ms | 365.66 ms | 54.42 ms |
ddc97ad | 331.45 ms | 384.06 ms | 52.61 ms |
d53c6fa | 282.83 ms | 344.00 ms | 61.17 ms |
f922f8f | 332.31 ms | 374.67 ms | 42.37 ms |
547db82 | 453.40 ms | 482.88 ms | 29.48 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
03e4c9b | 6.35 MiB | 7.42 MiB | 1.07 MiB |
0a82a1e | 6.15 MiB | 7.11 MiB | 981.82 KiB |
6fedcab | 6.33 MiB | 7.30 MiB | 987.83 KiB |
803f3a9 | 6.46 MiB | 7.48 MiB | 1.02 MiB |
ffae3e3 | 6.26 MiB | 7.20 MiB | 958.78 KiB |
bf4aed7 | 6.06 MiB | 7.03 MiB | 997.04 KiB |
ddc97ad | 6.16 MiB | 7.14 MiB | 1003.75 KiB |
d53c6fa | 6.16 MiB | 7.14 MiB | 1011.18 KiB |
f922f8f | 5.94 MiB | 6.95 MiB | 1.01 MiB |
547db82 | 6.49 MiB | 7.56 MiB | 1.07 MiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d089990 | 1206.19 ms | 1233.08 ms | 26.89 ms |
6aab859 | 1245.14 ms | 1247.59 ms | 2.45 ms |
dd5521e | 1254.28 ms | 1263.37 ms | 9.09 ms |
07cd9e8 | 1237.04 ms | 1257.50 ms | 20.46 ms |
21845e2 | 1279.37 ms | 1298.81 ms | 19.45 ms |
a7acb24 | 1296.71 ms | 1317.69 ms | 20.98 ms |
e4d5aa8 | 1224.15 ms | 1245.72 ms | 21.57 ms |
a61674e | 1275.51 ms | 1290.81 ms | 15.30 ms |
6034b0a | 1244.89 ms | 1270.22 ms | 25.33 ms |
73d70bf | 1249.08 ms | 1268.41 ms | 19.33 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d089990 | 8.33 MiB | 9.40 MiB | 1.07 MiB |
6aab859 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
dd5521e | 8.43 MiB | 9.97 MiB | 1.54 MiB |
07cd9e8 | 8.38 MiB | 9.77 MiB | 1.40 MiB |
21845e2 | 8.15 MiB | 9.12 MiB | 991.34 KiB |
a7acb24 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
e4d5aa8 | 8.33 MiB | 9.62 MiB | 1.29 MiB |
a61674e | 8.10 MiB | 9.16 MiB | 1.07 MiB |
6034b0a | 8.33 MiB | 9.40 MiB | 1.07 MiB |
73d70bf | 8.38 MiB | 9.70 MiB | 1.33 MiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! that was a quick 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's merge the mutable data PR then update this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
📜 Description
FeatureFlagIntegration
💡 Motivation and Context
Closes #2747
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled