Skip to content

chore: disable sff & frame delay detection on web, linux and windows #2182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2024
Merged

chore: disable sff & frame delay detection on web, linux and windows #2182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f39851
disable
buenaflor Jul 18, 2024
e71e276
update
buenaflor Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

## Unreleased

### Fixes

- Disable sff & frame delay detection on web, linux and windows ([#2182](https://github.com/getsentry/sentry-dart/pull/2182))
- Display refresh rate is locked at 60 for these platforms which can lead to inaccurate metrics

### Improvements

- Capture meaningful stack traces when unhandled errors have empty or missing stack traces ([#2152](https://github.com/getsentry/sentry-dart/pull/2152))
Expand Down
7 changes: 6 additions & 1 deletion flutter/lib/src/sentry_flutter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,12 @@ mixin SentryFlutter {

options.addEventProcessor(PlatformExceptionEventProcessor());

options.addPerformanceCollector(SpanFrameMetricsCollector(options));
// Disabled for web, linux and windows until we can reliably get the display refresh rate
if (options.platformChecker.platform.isAndroid ||
options.platformChecker.platform.isIOS ||
options.platformChecker.platform.isMacOS) {
options.addPerformanceCollector(SpanFrameMetricsCollector(options));
}

_setSdk(options);
}
Expand Down