-
-
Notifications
You must be signed in to change notification settings - Fork 271
Add support for sqflite #1306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add support for sqflite #1306
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
5a8e98c
Add support for sqflite
66e7544
fix
marandaneto 29c9e80
add CI workflow
marandaneto c7caa13
fix ci workflow name
marandaneto 77f7b03
add craft
marandaneto aa8398d
add wrappers
marandaneto bd9aaf6
implement more queries and add example
marandaneto 2c28b44
add transaction wrapper
marandaneto 2e880ff
add sample example
marandaneto a8174c7
fix readme
marandaneto 4c3c624
fix conflicts
marandaneto a949bae
add batch support
marandaneto 0cbb95b
add pending sdk version, name and bail out if tracing not enabled
marandaneto d111dcb
fix integration name
marandaneto aec5fd1
fix CI
marandaneto 656b3c7
fix CI
marandaneto 497ab2a
fix gitignore
marandaneto 4e54794
fix analyse
marandaneto 6246577
fix deps
marandaneto 6335b07
add flutter dep
marandaneto 9db80da
fix java version
marandaneto 3197196
fix java version
marandaneto 85dd630
add changelog
marandaneto 1fb22a6
remove files
marandaneto b389605
review
marandaneto 705ea5b
tests for the changes on the dart package
marandaneto f777df0
more tests
marandaneto 4ba8dd1
Merge branch 'v7.0.0' into chore/sqflite
marandaneto f574c43
batch tests
marandaneto 6765e2b
add more tests
marandaneto 56468d2
fix
marandaneto c302025
fix changelog
marandaneto 78de98b
Merge branch 'main' into chore/sqflite
marandaneto 859dd38
fix formatting
marandaneto 0328f10
more tests
marandaneto 25bb9bf
fix
marandaneto 3860e0e
fix versioning
marandaneto 06ab99b
remove comments
marandaneto 8daa8e6
fix
marandaneto 232f68e
Merge branch 'main' into chore/sqflite
marandaneto 70b86e5
fix conflict
marandaneto 6fbe91b
fix changelog
marandaneto 5475333
add dio version test
marandaneto ba1a027
Merge branch 'main' into chore/sqflite
marandaneto e56ad39
Merge branch 'main' into chore/sqflite
marandaneto c6a2a62
fix
marandaneto a6c782a
remove comment
marandaneto 73cc5f9
fix
marandaneto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,7 @@ on: | |
| - 'logging/**' | ||
| - 'flutter/**' | ||
| - 'dio/**' | ||
| - 'sqflite/**' | ||
|
|
||
| jobs: | ||
| cancel-previous-workflow: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| name: sentry-sqflite | ||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| - release/** | ||
| pull_request: | ||
| paths-ignore: | ||
| - 'logging/**' | ||
| - 'flutter/**' | ||
| - 'dio/**' | ||
| - 'file/**' | ||
|
|
||
| jobs: | ||
| cancel-previous-workflow: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Cancel Previous Runs | ||
| uses: styfle/cancel-workflow-action@b173b6ec0100793626c2d9e6b90435061f4fc3e5 # [email protected] | ||
| with: | ||
| access_token: ${{ github.token }} | ||
|
|
||
| build: | ||
| name: ${{ matrix.target }} | ${{ matrix.os }} | ${{ matrix.sdk }} | ||
| runs-on: ${{ matrix.os }} | ||
| timeout-minutes: 30 | ||
| defaults: | ||
| run: | ||
| shell: bash | ||
| strategy: | ||
| fail-fast: false | ||
| # max-parallel: 4 | ||
| matrix: | ||
| os: [ubuntu-latest, windows-latest, macos-latest] | ||
| target: ['ios', 'android', 'macos', 'linux', 'windows'] | ||
| sdk: ['stable', 'beta'] | ||
| exclude: | ||
| - os: ubuntu-latest | ||
| target: ios | ||
| - os: ubuntu-latest | ||
| target: macos | ||
| - os: ubuntu-latest | ||
| target: windows | ||
| - os: windows-latest | ||
| target: ios | ||
| - os: windows-latest | ||
| target: macos | ||
| - os: windows-latest | ||
| target: linux | ||
| # macos-latest is taking hours due to limited resources | ||
| - os: macos-latest | ||
| target: android | ||
| - os: macos-latest | ||
| target: web | ||
| - os: macos-latest | ||
| target: linux | ||
| - os: macos-latest | ||
| target: windows | ||
| # Bad CPU type in executable | ||
| - os: macos-latest | ||
| sdk: beta | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
|
|
||
| - uses: actions/setup-java@v3 | ||
| if: ${{ matrix.target == 'android' }} | ||
| with: | ||
| java-version: '11' | ||
| distribution: 'adopt' | ||
|
|
||
| # Install required dependencies for Flutter on Linux on Ubuntu | ||
| - name: 'Setup Linux' | ||
| run: | | ||
| sudo apt update | ||
| sudo apt install -y cmake dbus libblkid-dev libgtk-3-dev liblzma-dev ninja-build pkg-config xvfb | ||
| sudo apt install -y network-manager upower | ||
| if: matrix.os == 'ubuntu-latest' | ||
|
|
||
| - uses: subosito/flutter-action@dbf1fa04f4d2e52c33185153d06cdb5443aa189d # pin@v2 | ||
| with: | ||
| channel: ${{ matrix.sdk }} | ||
|
|
||
| - run: flutter upgrade | ||
|
|
||
| - name: Pub Get | ||
| run: | | ||
| cd sqflite | ||
| flutter pub get | ||
|
|
||
| - name: Test VM with coverage | ||
| if: runner.os != 'macOS' | ||
| run: | | ||
| cd sqflite | ||
| flutter test --coverage --test-randomize-ordering-seed=random | ||
|
|
||
| - uses: codecov/codecov-action@d9f34f8cd5cb3b3eb79b3e4b5dae3a16df499a70 # pin@v3 | ||
| if: runner.os == 'Linux' && matrix.sdk == 'stable' && matrix.target == 'linux' | ||
| with: | ||
| name: sentry_sqflite | ||
| file: ./sqflite/coverage/lcov.info | ||
| functionalities: 'search' # remove after https://github.com/codecov/codecov-action/issues/600 | ||
|
|
||
| - uses: VeryGoodOpenSource/very_good_coverage@84e5b54ab888644554e5573dca87d7f76dec9fb3 # [email protected] | ||
| if: runner.os == 'Linux' && matrix.sdk == 'stable' && matrix.target == 'linux' | ||
| with: | ||
| path: './sqflite/coverage/lcov.info' | ||
| min_coverage: 80 | ||
|
|
||
| analyze: | ||
| uses: ./.github/workflows/analyze.yml | ||
| with: | ||
| package: sqflite | ||
| sdk: flutter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
irrelevant to the sqflite, but is there some Set analogy in dart which you could use here maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have but that would be breaking, I'll consider it in the next refactoring.