Skip to content

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Jun 27, 2025

📜 Description

Allows bundles to be associated so it shows up in the sourcemaps site, this does not affect symbolication - this is only informational

💡 Motivation and Context

Closes #330

💚 How did you test it?

Manually tested E2E & test suite that checks that the correct commands are executed

image

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 9659c67

@buenaflor
Copy link
Contributor Author

buenaflor commented Jun 27, 2025

@denrase I guess this is semantics but if we automatically pick up a release from pubspec e.g 1.0.0+1

should we then during sourcemaps upload:

  • set release to 1.0.0+1 and dist to 1
  • or set release to 1.0.0 and dist to 1
  • or only set release to 1.0.0+1 because it has a build number already?

It's not really important because it's only for informational purposes (see screenshot), but I guess we should align anyway

@buenaflor
Copy link
Contributor Author

Let's keep it as it is right now, it's only informational anyway. If someone is confused by it in the future we can revisit again

@buenaflor buenaflor marked this pull request as ready for review June 30, 2025 08:41
@buenaflor buenaflor requested a review from stefanosiano as a code owner June 30, 2025 08:41
@buenaflor buenaflor requested a review from denrase June 30, 2025 13:11
@buenaflor buenaflor enabled auto-merge (squash) June 30, 2025 13:36
@buenaflor buenaflor merged commit 036642c into main Jun 30, 2025
19 checks passed
@buenaflor buenaflor deleted the feat/associate-releases-with-debug-id branch June 30, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release version and dist not set by default with pubspec.yaml

3 participants