-
-
Couldn't load subscription status.
- Fork 32
Add missing prefix to source file upload #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ['dart'], | ||
| releaseDartFilesParams, | ||
| release, | ||
| 'lib', | ||
| '~/lib/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you know what happens for packages relying on other packages?
e.g I have a main app that consumes internal modules A and B
I guess this would only cover uploading and prefixing files correctly for main app so frames coming from module A and B would not have source context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as the modules are within the lib folder, it "should" be fine. If they are outside, we are not supporting this currently, as we intentionally moved away from scanning the whole folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that can be a usecase though right? when they have internal libraries that they consume for example. we don't have to support it now but I guess we can create an issue and see if people are interested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍 we should also think about writing proper end-to-end tests for this in the future
|
@buenaflor Put this in draft as i want to test more scenarios when we get feedback. |
|
change looks good to me |
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Add missing prefix to source file upload ([#306](https://github.com/getsentry/sentry-dart-plugin/pull/306))If none of the above apply, you can opt out of this check by adding |
📜 Description
The source maps reference sources from the root folder. So when we added
libas a folder for sources to upload, we also need to addlibas a prefix so the reference is correct.💡 Motivation and Context
Closes #299
Closes #304
💚 How did you test it?
Updated unit test.
📝 Checklist