Skip to content

Only upload .dart files with upload-sourcemaps when upload_sources is enabled #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Only upload .dart files with upload-sourcemaps when upload_sources is enabled #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4a84d1
Only upload dart files with `upload-sourcemaps` when `upload_sources`…
denrase Jul 8, 2024
1d16ac3
add changelog entry
denrase Jul 8, 2024
bc77a22
update comments
denrase Jul 8, 2024
6867742
add changelog info
denrase Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## Unreleased

### Fixes

- Only upload `.dart` files with `upload-sourcemaps` when `upload_sources` is enabled ([#247](https://github.com/getsentry/sentry-dart-plugin/pull/247))
- Enable `upload_sources` to opt in to Flutter web source context

## 2.1.0

### Features
Expand Down
19 changes: 11 additions & 8 deletions lib/sentry_dart_plugin.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,17 +140,20 @@ class SentryDartPlugin {

await _executeAndLog('Failed to upload source maps', releaseJsFilesParams);

// upload source maps (dart)
List<String> releaseDartFilesParams = [];
releaseDartFilesParams.addAll(params);

_addExtensionToParams(['dart'], releaseDartFilesParams, release,
_configuration.buildFilesFolder);
if (_configuration.uploadSources) {
// upload source files (dart)
List<String> releaseDartFilesParams = [];
releaseDartFilesParams.addAll(params);

_addExtensionToParams(['dart'], releaseDartFilesParams, release,
_configuration.buildFilesFolder);

_addWait(releaseDartFilesParams);
_addWait(releaseDartFilesParams);

await _executeAndLog(
'Failed to upload source maps', releaseDartFilesParams);
await _executeAndLog(
'Failed to upload source files', releaseDartFilesParams);
}

Log.taskCompleted(taskName);
}
Expand Down
8 changes: 0 additions & 8 deletions test/plugin_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,6 @@ void main() {
expect(commandLog, [
'$cli $args releases $orgAndProject new $release',
'$cli $args releases $orgAndProject files $release upload-sourcemaps $buildDir/build/web --ext map --ext js',
'$cli $args releases $orgAndProject files $release upload-sourcemaps $buildDir --ext dart',
'$cli $args releases $orgAndProject set-commits $release --auto',
'$cli $args releases $orgAndProject finalize $release'
]);
Expand All @@ -215,7 +214,6 @@ void main() {
expect(commandLog, [
'$cli $args releases $orgAndProject new $configRelease',
'$cli $args releases $orgAndProject files $configRelease upload-sourcemaps $buildDir/build/web --ext map --ext js',
'$cli $args releases $orgAndProject files $configRelease upload-sourcemaps $buildDir --ext dart',
'$cli $args releases $orgAndProject set-commits $configRelease --auto',
'$cli $args releases $orgAndProject finalize $configRelease'
]);
Expand All @@ -238,7 +236,6 @@ void main() {
expect(commandLog, [
'$cli $args releases $orgAndProject new $release',
'$cli $args releases $orgAndProject files $release upload-sourcemaps $buildDir/build/web --ext map --ext js --dist $build',
'$cli $args releases $orgAndProject files $release upload-sourcemaps $buildDir --ext dart --dist $build',
'$cli $args releases $orgAndProject set-commits $release --auto',
'$cli $args releases $orgAndProject finalize $release'
]);
Expand All @@ -260,7 +257,6 @@ void main() {
expect(commandLog, [
'$cli $args releases $orgAndProject new $configRelease',
'$cli $args releases $orgAndProject files $configRelease upload-sourcemaps $buildDir/build/web --ext map --ext js --dist $build',
'$cli $args releases $orgAndProject files $configRelease upload-sourcemaps $buildDir --ext dart --dist $build',
'$cli $args releases $orgAndProject set-commits $configRelease --auto',
'$cli $args releases $orgAndProject finalize $configRelease'
]);
Expand All @@ -282,7 +278,6 @@ void main() {
expect(commandLog, [
'$cli $args releases $orgAndProject new $release',
'$cli $args releases $orgAndProject files $release upload-sourcemaps $buildDir/build/web --ext map --ext js --dist $configDist',
'$cli $args releases $orgAndProject files $release upload-sourcemaps $buildDir --ext dart --dist $configDist',
'$cli $args releases $orgAndProject set-commits $release --auto',
'$cli $args releases $orgAndProject finalize $release'
]);
Expand All @@ -307,7 +302,6 @@ void main() {
expect(commandLog, [
'$cli $args releases $orgAndProject new $release',
'$cli $args releases $orgAndProject files $release upload-sourcemaps $buildDir/build/web --ext map --ext js --dist $configDist',
'$cli $args releases $orgAndProject files $release upload-sourcemaps $buildDir --ext dart --dist $configDist',
'$cli $args releases $orgAndProject set-commits $release --auto',
'$cli $args releases $orgAndProject finalize $release'
]);
Expand All @@ -330,7 +324,6 @@ void main() {
expect(commandLog, [
'$cli $args releases $orgAndProject new $configRelease',
'$cli $args releases $orgAndProject files $configRelease upload-sourcemaps $buildDir/build/web --ext map --ext js --dist $configDist',
'$cli $args releases $orgAndProject files $configRelease upload-sourcemaps $buildDir --ext dart --dist $configDist',
'$cli $args releases $orgAndProject set-commits $configRelease --auto',
'$cli $args releases $orgAndProject finalize $configRelease'
]);
Expand All @@ -355,7 +348,6 @@ void main() {
expect(commandLog, [
'$cli $args releases $orgAndProject new $configRelease',
'$cli $args releases $orgAndProject files $configRelease upload-sourcemaps $buildDir/build/web --ext map --ext js --dist $configDist',
'$cli $args releases $orgAndProject files $configRelease upload-sourcemaps $buildDir --ext dart --dist $configDist',
'$cli $args releases $orgAndProject set-commits $configRelease --auto',
'$cli $args releases $orgAndProject finalize $configRelease'
]);
Expand Down