Skip to content

Conversation

@denrase
Copy link
Collaborator

@denrase denrase commented May 6, 2024

📜 Description

Add support for build files folder parameter

💡 Motivation and Context

Closes #228

💚 How did you test it?

Unit Tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 17ff290

@denrase denrase marked this pull request as ready for review May 6, 2024 10:29
Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Giancarlo Buenaflor <[email protected]>
@denrase
Copy link
Collaborator Author

denrase commented May 6, 2024

@buenaflor I assumed that web path behaviour would stay the same and users can also specify a custom path there as the need it. Don't think we can assume web path to be correct in relation to a custom build path users provide, no?

@buenaflor
Copy link
Contributor

Don't think we can assume web path to be correct in relation to a custom build path users provide, no?

yeah, was just wondering if it makes sense to call that out somehow but not sure, maybe not?

@denrase
Copy link
Collaborator Author

denrase commented May 7, 2024

@buenaflor I changed the naming to match the other parameter and added some context in the readme

@denrase denrase requested a review from buenaflor May 7, 2024 08:22
Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@denrase denrase merged commit fa25112 into main May 7, 2024
@denrase denrase deleted the feat/build-files-folder branch May 7, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

override buildFilesFolder via arguments

3 participants