-
-
Couldn't load subscription status.
- Fork 32
Add support for build files folder parameter #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have concerns about the web side of this?
Co-authored-by: Giancarlo Buenaflor <[email protected]>
|
@buenaflor I assumed that web path behaviour would stay the same and users can also specify a custom path there as the need it. Don't think we can assume web path to be correct in relation to a custom build path users provide, no? |
yeah, was just wondering if it makes sense to call that out somehow but not sure, maybe not? |
|
@buenaflor I changed the naming to match the other parameter and added some context in the readme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
📜 Description
Add support for build files folder parameter
💡 Motivation and Context
Closes #228
💚 How did you test it?
Unit Tests
📝 Checklist