Add support for Kotlin 2.1.20 #871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markushi
requested review from
adinauer,
lcian,
romtsn and
stefanosiano
as code owners
…ntry/sentry-android-gradle-plugin into markushi/fix/kotlin-2-1-20-support
romtsn
reviewed
Apr 30, 2025
| tasks.withType<KotlinCompile>().configureEach { | ||
| kotlinOptions { | ||
| jvmTarget = JavaVersion.VERSION_11.toString() | ||
| languageVersion = "1.9" |
There was a problem hiding this comment.
not sure if it has to be a breaking change, but probably impact is quite low as it's nearly 2 years old.
There was a problem hiding this comment.
Let me try to switch to the same version as the main plugin
There was a problem hiding this comment.
I guess it's fine, we just have to check if the compiler plugin is going to work on kotlin < 1.9 with this options? I assume it probably should
|
I finally finished the manual testing with the following Kotlin configurations (mixed in some Gradle, AGP, KSP versions as well):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixes #868
💡 Motivation and Context
Introduces two source sets, one compiled against 1.9.20 and one for 2.1.20 - this way binary incompatibility due to changes in default parameter values are avoided.
💚 How did you test it?
Manual testing
📝 Checklist
🔮 Next steps