feat(envoy): Allow to pass arbitrary http headers to upstream calls #4713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Putting to draft, waiting for feedback from @gi0baro |
@dmajere while the security concern around headers was tackled by @oioki, I still don't get why we need to set headers for relay specifically. Is this only to support the legacy DSNs in the US region? Or also 'cause pops talks to frontend? If it's the latter, can't we just change the routing pops->main to talk directly to upstream releays through traffic director in place of frontend and leave relay code as it is? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to configure and pass arbitrary headers to upstream calls.
#4712