Skip to content

HTTP-99 Add support for generic json and URL query creator #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 22, 2025
Merged

HTTP-99 Add support for generic json and URL query creator #149

merged 16 commits into from
May 22, 2025

Conversation

davidradl
Copy link
Collaborator

Description

Added support for generic json and URL query creator. This is a generic json query creator, aiming to allow the common json requests to be constructed using table configuration, rather than requiring custom java code to be written.

Resolves HTTP99

PR Checklist

This was referenced Apr 16, 2025
Open
Closed
@davidradl davidradl mentioned this pull request Apr 16, 2025
Open
@davidradl davidradl force-pushed the http99 branch 2 times, most recently from d78aa5e to 7c81ffe Compare April 16, 2025 15:04
maciejmaciejko-gid
maciejmaciejko-gid reviewed Apr 17, 2025
View reviewed changes
@davidradl
Copy link
Collaborator Author

@maciejmaciejko-gid thanks for the feedback, I have implemented most of it. The formatting is somewhat dictated by the check style. It is especially harsh on new lines. I have left the commits unsquashed as previously requested by @grzegorz8 .

grzegorz8
grzegorz8 reviewed Apr 22, 2025
View reviewed changes
grzegorz8
grzegorz8 reviewed May 2, 2025
View reviewed changes
...onnectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreatorFactory.java Outdated
@SuppressWarnings({"checkstyle:RegexpSingleline", "checkstyle:LineLength"})
public class GenericJsonAndUrlQueryCreatorFactory implements LookupQueryCreatorFactory {
private static final long serialVersionUID = 1L;
private static final Logger log =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see custom definition of log instead of @Slf4j.

davidradl added 9 commits May 6, 2025 17:10
@davidradl davidradl requested a review from grzegorz8 May 7, 2025 14:24
@davidradl
Copy link
Collaborator Author

@grzegorz8 @maciejmaciejko-gid I think I have addressed everything. LGTM.

@davidradl
Copy link
Collaborator Author

@grzegorz8 I suggest we leave this to the end of the 21st of May for @maciejmaciejko-gid and @kristoffSC to provide any more feedback , we get approves or no responses then we should merge then. WDYT?

@grzegorz8 grzegorz8 merged commit d200f1d into getindata:main May 22, 2025
3 checks passed
davidradl added a commit to davidradl/flink-http-connector that referenced this pull request Sep 11, 2025
@davidradl
HTTP-99 Add support for generic json and URL query creator (getindata…
97f73e4 
…#149)

Signed-off-by: davidradl <[email protected]>
davidradl added a commit to davidradl/flink-http-connector that referenced this pull request Sep 11, 2025
@davidradl
HTTP-99 Add support for generic json and URL query creator (getindata…
869b275 
…#149)

Signed-off-by: davidradl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzegorz8 grzegorz8 grzegorz8 approved these changes

@maciejmaciejko-gid maciejmaciejko-gid maciejmaciejko-gid approved these changes

@kristoffSC kristoffSC Awaiting requested review from kristoffSC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidradl @grzegorz8 @maciejmaciejko-gid