Skip to content

#162 Configuration refactoring #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mbastian merged 10 commits into from
Apr 29, 2023
Merged

#162 Configuration refactoring #168

mbastian merged 10 commits into from
Apr 29, 2023

Conversation

@mbastian
Copy link
Member

@mbastian mbastian commented Apr 29, 2023 •
edited
Loading

Configuration is a bit cumbersome to use

  • Create Configuration builder to facilitate unit test
  • Deprecate setters on the Configuration class in profit of the builder
  • Move relevant static configuration to Configuration
  • Add unit tests for different configurations
  • Update documentation

#162

@mbastian mbastian changed the title Config extend #162 Configuration refactoring Apr 29, 2023
@mbastian mbastian marked this pull request as ready for review April 29, 2023 19:28
@mbastian mbastian added this to the 0.7.0 milestone Apr 29, 2023
@mbastian mbastian merged commit 52590fd into master Apr 29, 2023
@mbastian mbastian deleted the config-extend branch October 3, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mbastian