ENH: Read filelike objects

[Sangarshanan]

Tried to support reading of file-like objects using geopandas, looking for feedback and suggestions
Ref #388 and #1323

[martinfleis]

Thanks for the PR! This looks good. What are all the possible options we might want to support (and test)? Drawing from linked issues:

• tempfile.TemporaryFile (is it supported now? can we support it and test it?)
• pathlib.Path
• String IO
• binary IO
• raw IO
• Bytes IO

Anything else to support?

We should also mention all these options in documentation (both User Guide and docstring).

[Sangarshanan]

Yup it is possible to read tempfile.TemporaryFile added a test for it, also it is actually possible to read any object with a read() method now. Things I see missing in the test are py.path and s3 objects, url's. But py.path doc says that it's in maintenance mode and has asked to refer pathlib for path operations. I am also checking out reading s3 urls (possible with fiona) and even streaming s3 objects ref: pandas-dev/pandas#22520 but maybe that is a separate issue

Should I address the user guide changes here?

[martinfleis]

Should I address the user guide changes here?

Ideally yes.

S3 can go to separate PR as it might be more tricky.

[Sangarshanan]

I have added some basic content to the user guide, not sure if should I add more detailed examples explaining every file like object supported?

[martinfleis]

I don't think we need to add more details. Docstring clearly indicates that there are other options apart from file path.

I have pushed some minor style cleaning. I recommend using pre-commit hook to make sure that the code follows black and flake8 - https://geopandas.readthedocs.io/en/latest/contributing.html#style-guide-linting

Thanks!

[martinfleis]

Thank you @Sangarshanan!