Remove the need to Box rcl_node_t #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to recreate the crash that happens in humble, as discussed here. It does seem that in Humble rcl is doing some questionable things with the
rcl_node_t
address.This PR offers an alternative solution that does not require us to Box the
rcl_node_t
. Instead we initialize thercl_node_t
while it is already positioned inside theNodeHandle
. Since theNodeHandle
has a fixed memory address throughout its lifetime, thercl_node_t
will also have a fixed address.The only downside is we need to add another variable to
NodeHandle
to track whether thercl_node_t
was successfully initialized, otherwise it might attempt to callrcl_node_fini
on an invalidrcl_node_t
instance which lead to bad and confusing behavior in the tests. I think overall this is less disruptive than adding a layer of indirection torcl_node_t
.