Skip to content

Fix annotation metadata driver with Doctrine proxies #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 2, 2021
Merged

Fix annotation metadata driver with Doctrine proxies #301

merged 3 commits into from
Feb 2, 2021

Conversation

pierredup
Copy link
Contributor

Fixed problem where geocoding was not performed, when the changed entity was proxied by Doctrine.

(Ref: #219)

@norkunas
Copy link
Member

norkunas commented Feb 2, 2021

Hello and thanks.
One question - maybe would be better to use ClassUtils from doctrine common?

@pierredup
Copy link
Contributor Author

Thanks, @norkunas, I've updated the PR to use ClassUtils

@norkunas norkunas merged commit e0ae2b2 into geocoder-php:master Feb 2, 2021
@norkunas
Copy link
Member

norkunas commented Feb 2, 2021

Thank you :)

@pierredup pierredup deleted the doctrine-proxy branch February 2, 2021 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norkunas norkunas norkunas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierredup @norkunas