Issue 5639 - Cast aggregation results back to correct type #5687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-the-type-of-integer-fields
…s-the-type-of-integer-fields
Base automatically changed from
5409-write-java-side-df-query-code
to
develop
October 14, 2025 12:27
patchwork01
removed
the
pr-stacked-middle
…s-the-type-of-integer-fields
…s-the-type-of-integer-fields
…s-the-type-of-integer-fields
…s-the-type-of-integer-fields
…s-the-type-of-integer-fields
rtjd6554
added
the
needs-reviewer
…s-the-type-of-integer-fields
patchwork01
reviewed
Oct 24, 2025
|
|
||
| impl PartialEq for NonNullable { | ||
| fn eq(&self, other: &Self) -> bool { | ||
| Arc::ptr_eq(&self.inner, &other.inner) && self.func_name == other.func_name |
There was a problem hiding this comment.
It looks like equal NonNullables won't always point to the same inner implementation. In the AggregateUDFImpl implementation there's a simplify method that clones the inner function.
What is the implication of this? Why does it need a PartialEq or Eq implementation?
Is it worth adding a comment to explain this if it's needed?
|
|
||
| /// A UDF for performing primitive casting, but without producing errors if a narrowing conversion | ||
| /// would be outside the target type's range. Casts are performed in the "standard" way, i.e. truncating | ||
| /// upper bits on a narrowing conversion. |
There was a problem hiding this comment.
Please can we explain why this is necessary in the comment? We could link to the original issue.
| "| 6 | 66 |", | ||
| "+------+------+", | ||
| ]; | ||
| assert_batches_neq!(expected, &frame.collect().await?); |
There was a problem hiding this comment.
Can we assert what actually comes back here? We could explain what's wrong with it in a comment?
patchwork01
removed
the
needs-reviewer
…s-the-type-of-integer-fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Issue
Feature". Note that before an issue is finished, you can still make a pull request by raising a separate issue
for your progress.
Tests
Documentation
separate issue for that below.