chore: add missing @babel/runtime dependencies
#32954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
ascorbic
force-pushed
the
chore/babel-runtime
branch
from
03d23ac to
245bb2a
Compare
ascorbic
changed the title
@babel/runtime dependencies
wardpeet
added
type: maintenance
wardpeet
approved these changes
Aug 30, 2021
|
The test failures seem to be unrelated (and seem to be a weird snapshot failing which actually is identical) |
3 tasks
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
Co-authored-by: gatsbybot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
@babel/runtimeas a dependency to all packages that are missing it. Because packages are all compiled with@babel/plugin-transform-runtime, they all need it as a dependency. It usually works ok because it is a dependency ofgatsby, but it's good practice to not rely on transitive dependencies, and in some situations can be tree-shaken away.