Support Websockets #314
Merged
Support Websockets #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songz
reviewed
Dec 5, 2019
src/server/server.ts
Outdated
| if (port) | ||
| return proxy.ws(req, socket, { target: `http://127.0.0.1:${port}` }) | ||
|
|
||
| server.listen(443) |
Collaborator
There was a problem hiding this comment.
This is wrong. You can't listen to port 443 AFTER websocket connection.
songz
reviewed
Dec 5, 2019
src/server/server.ts
Outdated
| return `${prefix}${domain}` === req.headers.host | ||
| }) || {} | ||
| if (port) | ||
| return proxy.ws(req, socket, { target: `http://127.0.0.1:${port}` }) |
Collaborator
There was a problem hiding this comment.
don't hardcode the ip address, you already got the ip address from the variable.
songz
reviewed
Dec 5, 2019
src/server/server.ts
Outdated
| const { ip, port }: ProxyMapping = | ||
| mappings.find(({ subDomain, domain }) => { | ||
| const prefix = subDomain ? `${subDomain}.` : '' | ||
| return `${prefix}${domain}` === req.headers.host |
Collaborator
There was a problem hiding this comment.
return fullDomain === req.headers.host
songz
reviewed
Dec 5, 2019
src/server/server.ts
Outdated
| const mappings = getMappings() | ||
| const { ip, port }: ProxyMapping = | ||
| mappings.find(({ subDomain, domain, fullDomain }) => { | ||
| const prefix = subDomain ? `${subDomain}.` : '' |
Collaborator
There was a problem hiding this comment.
prefix is not an unused variable. please remove it
songz
reviewed
Dec 5, 2019
src/server/server.ts
Outdated
| const prefix = subDomain ? `${subDomain}.` : '' | ||
| return fullDomain === req.headers.host | ||
| }) || {} | ||
| if (port) return proxy.ws(req, socket, { target: `${ip}:${port}` }) |
songz
approved these changes
Dec 5, 2019
allopez7
approved these changes
Dec 6, 2019
hwong0305
pushed a commit
to hwong0305/myProxy
that referenced
this pull request
Dec 6, 2019
Support Websockets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.