Skip to content

Improve ScrollToTop component design #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2023
Merged

Improve ScrollToTop component design #3117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e7f9ab
Improve scrollTopArrow design
flacial Jul 14, 2023
8e63c7b
Merge remote-tracking branch 'upstream/master' into improve-lesson-pa…
flacial Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions components/ScrollTopArrow/ScrollTopArrow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,17 @@ const ScrollTopArrow: React.FC = () => {
<button
aria-label="Scroll to top"
title="Scroll to top"
className={`${styles['arrow']} border-0 p-0 bg-transparent`}
className={`${styles.arrow} d-grid justify-content-center align-content-center rounded-pill border-0 p-4`}
onClick={() => window.scrollTo(0, 0)}
>
<Image src="/assets/mdx/topArrow.svg" layout="fill" aria-hidden="true" />
<Image
src="/assets/mdx/topArrow.svg"
layout="fixed"
height={28}
width={28}
aria-hidden="true"
className="opacity-75"
/>
</button>
)
}
Expand Down
4 changes: 4 additions & 0 deletions components/ScrollTopArrow/scrollTopArrow.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
@use '../../scss/colors.module.scss';

.arrow {
background-color: colors.$bg-light-purple;
position: fixed;
height: 3em;
width: 3em;
Expand All @@ -9,4 +12,5 @@
z-index: 1;
top: 90%;
left: 90%;
box-shadow: 0 8px 20px 0 rgba(colors.$darkGray, 0.3);
}