Skip to content

Conversation

@flacial
Copy link
Member

@flacial flacial commented May 16, 2023

Changes

This PR makes accessing the settings page accessible to the students by displaying a link in the navbar dropdown menu.

Screenshot

image

Testing

  1. Click on the Settings link
  2. Make sure it's working

Related issues

#1629

@vercel
Copy link

vercel bot commented May 16, 2023

@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@flacial flacial requested a review from SlyBouhafs May 16, 2023 17:46
@vercel
Copy link

vercel bot commented May 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
c0d3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 8:28pm

@flacial flacial changed the title Make settings page public List the Settings page in the navbar dropdown menu May 16, 2023
@flacial
Copy link
Member Author

flacial commented May 16, 2023

What do you guys think? Is it the right location? Should it be named differently?

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #2991 (aa13de8) into master (90b58d8) will not change coverage.
The diff coverage is 100.00%.

❗ Current head aa13de8 differs from pull request most recent head 207e6e1. Consider uploading reports for the commit 207e6e1 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2991   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          191       191           
  Lines         3581      3582    +1     
  Branches       972       972           
=========================================
+ Hits          3581      3582    +1     
Impacted Files Coverage Δ
...onents/ProfileDropdownMenu/ProfileDropdownMenu.tsx 100.00% <ø> (ø)
constants/index.ts 100.00% <100.00%> (ø)

@flacial flacial added this pull request to the merge queue May 17, 2023
Merged via the queue into garageScript:master with commit 17dffae May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants