fix: Handle flagging an already flagged exercise #2693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #2693 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 189 189
Lines 3534 3539 +5
Branches 976 978 +2
=========================================
+ Hits 3534 3539 +5
|
SlyBouhafs
approved these changes
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation of flagging exercises in the DOJO design doc allows users to flag an exercise multiple times, resulting in a poor user experience. When a user attempts to flag an already flagged exercise, the backend returns an error and the frontend displays "Oops, something went wrong" without providing a clear reason for the error.
Changes
Screenshots
Testing
/exercises/js0pageConcerns
While this change addresses the immediate issue of poor user experience, it does not address the underlying problem of not allowing multiple flags per exercise. It would be better to allow multiple flags per exercise and provide an easy-to-use interface for reviewing and managing exercises with multiple-flags in the admin panel.