Next-Auth: Replace our auth system with next-auth #2543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the invocation of the GraphQL mutation `Login` with next-auth `signIn`. It also refactor how the login errors are set and when to redirect to curriculum.
Invoke `signIn` for Signing up instead of GraphQL `Login` mutation. It also refactor how the errors are set.
When next-auth handles setting the user password, it can set the session.
Refactor success.tsx to get the session from `getSession` method instead of extracting it from the request.
|
@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel. A member of the Team first needs to authorize it. |
flacial
commented
Nov 24, 2022
| discordAvatarUrl, | ||
| discordUsername, | ||
| isConnectedToDiscord: !!user.discordRefreshToken // using this to avoid a second fetch to get Discord username | ||
| isConnectedToDiscord: !!user.discordId // using this to avoid a second fetch to get Discord username |
Member
Author
There was a problem hiding this comment.
It has been changed to discordId because with how next-auth work, we can't put sensitive data such as the user Discord refresh token in the session.
Codecov Report
@@ Coverage Diff @@
## master #2543 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 186 186
Lines 3401 3414 +13
Branches 915 929 +14
=========================================
+ Hits 3401 3414 +13
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
songz
approved these changes
Dec 1, 2022
Since we migrated to next-auth, it's a bit hard to cache the session. By sending a request to get the session, the Apollo client will cache and the AppNav in the /curriculum page will display the login-signup buttons in loading-state
flacial
commented
Dec 3, 2022
| const router = useRouter() | ||
| const [logoutUser] = useLogoutMutation({ | ||
| update(cache) { | ||
| cache.modify({ |
Member
Author
There was a problem hiding this comment.
Expose the cache so we can modify without having to execute a query. There's probably a reason for setting the lessonStatus to an empty array.
flacial
commented
Dec 3, 2022
This reverts commit d5187ea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1935
Changed files in detail
success.tsx: We were using a set of middlewares to populate the user from. We now use the next-authgetSessionmethod to retrieve the session, and handle when a user is already connected to the same Discord account.login.tsxandsignup.tsx: We used the Apollo mutationssignupandloginto start the flow. This has been changed with the next-authsignInmethod.logoutContainer: We used the Apollo mutationlogoutto log out the user. We now usesignOutmethod by next-auth.nextAuth(session callback): Updated thesessioncallback to set thesession.useras the user from the database. This callback runs every time we callgetSessionoruseSession. The reason is that the data in the session stays outdated if one of them got updated from the client, such as if the user connected to discord. Created a custom credential provider that'll be used to handle the flow after the user confirm their email on signup flow.Fixes the bugs in the initial PR #1985:
Testing
Engineering changes 🔧
getSessionanduseSessionto get the user's session.Following
Handle the error thrown when a user is already connected to the same Discord account.