Skip to content

Conversation

@flacial
Copy link
Member

@flacial flacial commented Nov 21, 2022

Closes #2269

Description

After the recent changes to the <Alert /> component, the alerts in the admin/alerts page can be dismissed. As it's not a desirable thing, this PR aims at removing the ability to dismiss them.

Before

With dismiss image

After

Without dismiss image

@vercel
Copy link

vercel bot commented Nov 21, 2022

@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Nov 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
c0d3-app ✅ Ready (Inspect) Visit Preview Dec 4, 2022 at 8:41AM (UTC)

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #2530 (3173bb8) into master (a4309dd) will not change coverage.
The diff coverage is n/a.

❗ Current head 3173bb8 differs from pull request most recent head 33fb6ba. Consider uploading reports for the commit 33fb6ba to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2530   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          186       186           
  Lines         3385      3385           
  Branches       906       906           
=========================================
  Hits          3385      3385           
Impacted Files Coverage Δ
components/admin/alerts/AdminNewAlert.tsx 100.00% <ø> (ø)
pages/admin/alerts.tsx 100.00% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alert get dismissed in the admin/alerts page

2 participants