Add the ability to unlink discord from user profile page #2259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, when using the modal child components `Modal.*` (`Modal.Body`) it make our storybook tests fail with "Expect string or class but got undefined"
|
@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #2259 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 177 177
Lines 2990 3010 +20
Branches 801 801
=========================================
+ Hits 2990 3010 +20
|
bryanjenningz
approved these changes
Sep 4, 2022
bryanjenningz
approved these changes
Sep 5, 2022
flacial
commented
Sep 6, 2022
HS-90
reviewed
Sep 7, 2022
| </ModalFooter> | ||
| </Modal> | ||
| </> | ||
| ) : ( |
There was a problem hiding this comment.
Just a general suggestion. Would it be a good idea to have the above(what's shown if user already has discord linked) and below(shown if user doesn't have discord linked), as their own separate components, then pass in the function and states like show, handleUnlinkClick, handleConnectClick, etc as props?
There was a problem hiding this comment.
Great suggestion, I'll update the code!
HS-90
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2243
Merging this PR will add the ability for the user link/unlink their discord account from the profile page.
To test it:
/profile/YOUR_USERNAME or adminunlinkdiscord if you already connected your account orconnect to discordOnce the user unlink their account, the page reloads to load the new user data from the db (e.g., removing their profile picture).