[1 / 3] - Backend Functionality for Reset Password #223
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/c0d3/c0d3-app/9sjz6t20v |
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 47 +3
Lines 596 679 +83
Branches 138 151 +13
=========================================
+ Hits 596 679 +83
|
hwong0305
changed the title
| } | ||
|
|
||
| let user: any | ||
| if (userOrEmail.indexOf('@') !== -1) { |
There was a problem hiding this comment.
this could be a really useful util function, like const user = getUserByEmailOrUsername( userOrEmail )
Util function could do the throwing and input validation, making this reqPwReset function much smaller.
Util function will throw invalid input and user does not exist, so you are guaranteed to have a user object.
There was a problem hiding this comment.
If you make this a util function, we could potentially use this in login as well!
| user.expiration = null | ||
| user.forgotToken = null | ||
| user.password = hash | ||
| await user.save() |
There was a problem hiding this comment.
It's better to do this after changeChatPassword. This prevents our pw from being out of sync with chat.
| .max(TEXT_MAX, `Must be ${TEXT_MAX} characters or less`) | ||
| .trim('Leading and trailing value must be alphanumeric character') | ||
| .required('Required'), | ||
| password: Yup.string() |
There was a problem hiding this comment.
How does this affect the signup password validation?
There was a problem hiding this comment.
ooooo there's no password inputs for signup anymore :)
There was a problem hiding this comment.
I meant to move this to a different PR. I don't want to break production on this one.
3 participants
This is part of multiple PRs to add reset Password functionality
The second PR will add the resolvers to GraphQL server, update Signup and make changes to Front End
Screenshot for Reset Password Email Template
