PR: JS3 syntax errors and typos #2218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pauly48 is attempting to deploy a commit to the c0d3-prod Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Aug 24, 2022
Closed
Closed
This was
linked to
issues
Aug 24, 2022
Closed
Closed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
Thank you, brother!
…On Wed, Aug 24, 2022 at 4:33 PM Flacial ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good 🌟
—
Reply to this email directly, view it on GitHub
<#2218 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOWHKOM4WXAX6FFDMT3USGTV22WL7ANCNFSM57RC7YSQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Codecov Report
@@ Coverage Diff @@
## master #2218 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 172 172
Lines 2953 2953
Branches 793 793
=========================================
Hits 2953 2953 |
SlyBouhafs
reviewed
Aug 24, 2022
Contributor
Author
|
Here are the UI that should reflect the changes @anthonykhoa |
Cijin
approved these changes
Aug 25, 2022
SlyBouhafs
approved these changes
Aug 25, 2022
Contributor
Author
|
@sly, For some reason when an array is passed into a prototype function
this way, it has to have a semi-colon for some reason. Otherwise, it throws
an error in output.
There was another issue & PR that addressed a similar issue. (PR #2205)
#2205
…On Wed, Aug 24, 2022 at 4:45 PM Sly ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In content/lessons/js3/sublesson/objects.mdx
<#2218 (comment)>
:
> @@ -1936,11 +1936,10 @@ object `{}`, to store the results.
common element.
```jsx
-;[9, 8, 7, 8, 7, 7, 7].getMostCommon()[
+;[9, 8, 7, 8, 7, 7, 7].getMostCommon()
// returns 7 because it is the most common element
Why is there a semicolon at the start of these two lines?
—
Reply to this email directly, view it on GitHub
<#2218 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOWHKOLJRK2R6NWQK7G67SDV22X2PANCNFSM57RC7YSQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2200 #2201 #2209 #2212 #2217
UI results:
