feat(components): Update Alert component styles #2160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix the background issue with the urgent type - Update info and urgent styles - Change `img` tag to `next/image` as it's better in terms of performance - Add a class to change the image color with `filter` to purple
|
@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report
@@ Coverage Diff @@
## master #2160 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 171 171
Lines 2950 2950
Branches 796 796
=========================================
Hits 2950 2950
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SlyBouhafs
approved these changes
Aug 7, 2022
|
I like the new styles! |
JasirZaeem
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2145
Problem
Bootstrap
alert-dangerclass need the base classalertfor the element to have a background color. What's currently happening, We're applying the coloralert-dangerwithout the base styles fromalertwhich doesn't seem to be working.Solution
Add
alertclass to thedivcontaining the alert component elements.alert-dangertoalert alert-danger.Other changes
imgelement tonext/imagebecausenext/imagehas better performance and automatic image optimizations.