Skip to content

Conversation

kusmierz
Copy link

@kusmierz kusmierz commented Feb 15, 2018

This is solution 1 (so I won't update babel-eslint nor add proper tests) from @lydell #266 (comment). It also fixes crash for sortKeys rule. Not the best solution though, but should work in the meantime.

#266 #302 #293

@gajus any plans to update babel-eslint?

@gajus
Copy link
Owner

gajus commented Feb 15, 2018

Babel 7 RC is going to come out in a couple of days.

I will create/ accept a PR that updates to Babel then.

It would be reasonable to start working on one as the only breaking change outstanding is babel/babel#7358.

@lydell
Copy link

lydell commented Feb 15, 2018

Babel 7 RC is going to come out in a couple of days.

Babel 7 has been coming out in a couple of days for half a year. #266 (comment)

(All respect to the awesome Babel maintainers, I totally understand it takes time to get it right.)

@gajus
Copy link
Owner

gajus commented Feb 15, 2018

Babel 7 has been coming out in a couple of days for half a year. #266 (comment)

The point is that now there are no more planned breaking changes (other than the PR I have linked). At the time it was well known that breaking changes are to be expected.

@kusmierz
Copy link
Author

@gajus noDupeKeys started working, but sortKeys still broken. Any chances to fix it before Babel 7? :)

@kusmierz
Copy link
Author

@gajus babel/babel#7358 seems to be merged now. How could I help with that issue now?

@gajus
Copy link
Owner

gajus commented May 24, 2018

The next step would be babel-eslint to version 8.2.3. However, it breaks bunch of tests currently. I have not had time to investigate.

@IanVS
Copy link

IanVS commented Jul 9, 2018

#293 is closed/fixed, so I think this PR can be closed as well now?

@gajus gajus closed this Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants