This repository was archived by the owner on Apr 9, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 86
Add React.PureComponent to the list of default super classes #106
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
test/fixtures/code-class-extends-purecomponent-with-render-method/.babelrc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "plugins": [ | ||
| ["../../../src", { | ||
| "transforms": [{ | ||
| "transform": "transform-lib" | ||
| }] | ||
| }] | ||
| ] | ||
| } |
4 changes: 4 additions & 0 deletions
4
test/fixtures/code-class-extends-purecomponent-with-render-method/actual.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| import React, { PureComponent } from 'react'; | ||
| class Foo extends PureComponent { | ||
| render() {} | ||
| } |
25 changes: 25 additions & 0 deletions
25
test/fixtures/code-class-extends-purecomponent-with-render-method/expected.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import _transformLib from 'transform-lib'; | ||
| const _components = { | ||
| Foo: { | ||
| displayName: 'Foo' | ||
| } | ||
| }; | ||
|
|
||
| const _transformLib2 = _transformLib({ | ||
| filename: '%FIXTURE_PATH%', | ||
| components: _components, | ||
| locals: [], | ||
| imports: [] | ||
| }); | ||
|
|
||
| function _wrapComponent(id) { | ||
| return function (Component) { | ||
| return _transformLib2(Component, id); | ||
| }; | ||
| } | ||
|
|
||
| import React, { PureComponent } from 'react'; | ||
|
|
||
| const Foo = _wrapComponent('Foo')(class Foo extends PureComponent { | ||
| render() {} | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,6 @@ | ||
| export default class Foo extends React.Component {} | ||
| export default class extends React.Component {} | ||
| export class Foo extends React.Component {} | ||
| export default React.createClass({}); | ||
| export class Bar extends React.Component {} | ||
| export const bar = React.createClass({}); | ||
| export default class Baz { render() {} } | ||
| export default class { render() {} } | ||
| export class Baz { render() {} } | ||
| export class Boo { render() {} } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this change related to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the current spec only one default export can exist per module (I guess this has changed since this package was created). Babel now complains about this (maybe because the dependencies in this repo are not locked since it does not use yarn).