Skip to content
This repository was archived by the owner on May 17, 2019. It is now read-only.

Conversation

@akre54
Copy link
Contributor

@akre54 akre54 commented Feb 27, 2019

The actions object isn't actually required and causing an error in my project. Maybe this should rely directly on the types from fusion-rpc-redux?

@akre54
Copy link
Contributor Author

akre54 commented Feb 28, 2019

Ping @KevinGrandon @ganemone for review

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #191 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files           2        2           
  Lines          27       27           
  Branches        4        4           
=======================================
  Hits           25       25           
  Partials        2        2
Impacted Files Coverage Δ
src/hoc.js 88.88% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e846dca...091e01d. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #191 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files           2        2           
  Lines          27       27           
  Branches        4        4           
=======================================
  Hits           25       25           
  Partials        2        2
Impacted Files Coverage Δ
src/hoc.js 88.88% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e846dca...091e01d. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #191 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files           2        2           
  Lines          27       27           
  Branches        4        4           
=======================================
  Hits           25       25           
  Partials        2        2
Impacted Files Coverage Δ
src/hoc.js 88.88% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e846dca...091e01d. Read the comment docs.

@KevinGrandon
Copy link
Contributor

!merge

@old-fusion-bot old-fusion-bot bot merged commit cb55a06 into fusionjs:master Feb 28, 2019
@old-fusion-bot
Copy link

Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1617

@akre54 akre54 deleted the mapstate-actions-flowtype branch February 28, 2019 15:33
@alxmyth alxmyth mentioned this pull request Mar 4, 2019
@alxmyth alxmyth mentioned this pull request Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants