This repository was archived by the owner on May 17, 2019. It is now read-only.
Pass own props to mapStateToProps #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ganemone this one too? |
|
Could you add a test here? |
|
Looks good, just need lint and flow passing |
akre54
force-pushed
the
mapstate-own-props
branch
from
b3b753a to
a664653
Compare
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
+ Coverage 92.59% 93.33% +0.74%
==========================================
Files 2 2
Lines 27 30 +3
Branches 4 5 +1
==========================================
+ Hits 25 28 +3
Partials 2 2
Continue to review full report at Codecov.
|
|
Done |
ganemone
approved these changes
Feb 28, 2019
|
!merge |
|
Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1618 |
Merged
|
@ganemone any ideas when the next version will ship? |
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current design makes this un-ergonomic for things like grabbing url params from react-router.
This will also open up use cases like calling
connectfirst to massage data and then grabbing those props