This repository was archived by the owner on May 17, 2019. It is now read-only.
Import and export ActionType from dependency fusion-rpc-redux ^1.4.0 #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
=========================================
Coverage ? 93.33%
=========================================
Files ? 2
Lines ? 30
Branches ? 5
=========================================
Hits ? 28
Misses ? 0
Partials ? 2Continue to review full report at Codecov.
|
Merging latest changes
hugoe29
changed the title
lhorie
reviewed
Mar 4, 2019
src/index.js
Outdated
| ResponseError, | ||
| } from 'fusion-plugin-rpc'; | ||
| import {createRPCReducer} from 'fusion-rpc-redux'; | ||
| import {createRPCReducer, ActionType} from 'fusion-rpc-redux'; |
Contributor
There was a problem hiding this comment.
This should be import type {ActionType}
Contributor
|
Looks good to me! Thanks @hugoe29 ! |
Contributor
|
Oh, the export also needed to be changed. I went ahead and made the adjustment |
Contributor
Author
|
Thanks @lhorie |
lhorie
approved these changes
Mar 5, 2019
|
Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1655 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.