Skip to content
This repository was archived by the owner on May 17, 2019. It is now read-only.

Add peerDependency on react-redux #168

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Add peerDependency on react-redux #168

merged 1 commit into from
Jan 9, 2019

Conversation

@ganemone
Copy link
Contributor

@ganemone ganemone commented Jan 9, 2019

Fixes #166

@ganemone ganemone added the bugfix label Jan 9, 2019
@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #168 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files           2        2           
  Lines          27       27           
  Branches        4        4           
=======================================
  Hits           25       25           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c373527...e772ca1. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #168 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files           2        2           
  Lines          27       27           
  Branches        4        4           
=======================================
  Hits           25       25           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c373527...e772ca1. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 9, 2019 •
edited
Loading

Codecov Report

Merging #168 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files           2        2           
  Lines          27       27           
  Branches        4        4           
=======================================
  Hits           25       25           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c373527...e772ca1. Read the comment docs.

KevinGrandon
KevinGrandon approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@KevinGrandon KevinGrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we should do the breaking change and cut the upgrade today, but happy to approve for now.

@ganemone
Copy link
Contributor Author

ganemone commented Jan 9, 2019

!merge

@old-fusion-bot old-fusion-bot bot merged commit f660f2e into fusionjs:master Jan 9, 2019
@alxmyth alxmyth mentioned this pull request Jan 22, 2019
Closed
This was referenced Jan 22, 2019
Closed
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@KevinGrandon KevinGrandon KevinGrandon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ganemone @KevinGrandon