-
Notifications
You must be signed in to change notification settings - Fork 17
Constrain react-redux to <6 #195
Conversation
Adding version constraints since react-redux v6 isn't support.
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 5 5
Lines 62 62
Branches 12 12
=======================================
Hits 61 61
Partials 1 1Continue to review full report at Codecov.
|
3 similar comments
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 5 5
Lines 62 62
Branches 12 12
=======================================
Hits 61 61
Partials 1 1Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 5 5
Lines 62 62
Branches 12 12
=======================================
Hits 61 61
Partials 1 1Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 5 5
Lines 62 62
Branches 12 12
=======================================
Hits 61 61
Partials 1 1Continue to review full report at Codecov.
|
|
Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1697 |
|
Just wondering, why isn't react-redux v6+ supported? |
|
@kahwee @KevinGrandon ping |
|
I believe we are able to technically support it now, but there was some issues with performance in the latest release that was preventing us from upgrading. I'm not sure if there's an issue tracking this somewhere. CC @rtsao |
|
|
|
So, only because |
|
That's the issue that I faced, can't confirm the status of other things. It was a new project so didn't really test anything yet. |
Adding version constraints since react-redux v6 isn't support.