Skip to content
This repository was archived by the owner on May 17, 2019. It is now read-only.

Conversation

kahwee
Copy link
Contributor

@kahwee kahwee commented Mar 11, 2019

Adding version constraints since react-redux v6 isn't support.

Adding version constraints since react-redux v6 isn't support.
@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #195 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #195   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files           5        5           
  Lines          62       62           
  Branches       12       12           
=======================================
  Hits           61       61           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3e1ac0...449817d. Read the comment docs.

3 similar comments
@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #195 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #195   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files           5        5           
  Lines          62       62           
  Branches       12       12           
=======================================
  Hits           61       61           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3e1ac0...449817d. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #195 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #195   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files           5        5           
  Lines          62       62           
  Branches       12       12           
=======================================
  Hits           61       61           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3e1ac0...449817d. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #195 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #195   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files           5        5           
  Lines          62       62           
  Branches       12       12           
=======================================
  Hits           61       61           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3e1ac0...449817d. Read the comment docs.

@KevinGrandon KevinGrandon merged commit d309b3e into fusionjs:master Mar 12, 2019
@old-fusion-bot
Copy link

Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1697

This was referenced Mar 18, 2019
@ardok
Copy link

ardok commented Mar 20, 2019

Just wondering, why isn't react-redux v6+ supported?

@kahwee kahwee deleted the patch-1 branch March 21, 2019 08:05
@ardok
Copy link

ardok commented Mar 21, 2019

@kahwee @KevinGrandon ping

@KevinGrandon
Copy link
Contributor

I believe we are able to technically support it now, but there was some issues with performance in the latest release that was preventing us from upgrading. I'm not sure if there's an issue tracking this somewhere. CC @rtsao

@chirgjn
Copy link
Contributor

chirgjn commented Mar 26, 2019

withRPCRedux from fusion-plugin-rpc-redux-react v2.1.1 doesn't work with a container component using react-redux v6

@ardok
Copy link

ardok commented Mar 26, 2019

So, only because withRPCRedux?
If you don't use that, then you can use react-redux v6?

@chirgjn
Copy link
Contributor

chirgjn commented Mar 30, 2019

That's the issue that I faced, can't confirm the status of other things. It was a new project so didn't really test anything yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants