Storage "upload" method do not save metadata on Android #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

Yarikx opened this issue Nov 17, 2016 · 5 comments

Yarikx commented Nov 17, 2016

Metadata is not propagated to native code.

https://github.com/fullstackreact/react-native-firestack/blob/master/android/src/main/java/io/fullstack/firestack/FirestackStorage.java#L157
Metadata map is destructured but never used.

Collaborator

Salakar commented Nov 17, 2016

@Yarikx will sort on my branch (which is going to be merged for v3)

Author

Yarikx commented Nov 17, 2016

Salakar added a commit to Salakar/react-native-firestack that referenced this issue


          fixes fullstackreact#141

5968ee1

Collaborator

Salakar commented Nov 17, 2016

Done, on my branch.

Contributor

auser commented Nov 17, 2016

Looking forward to merge this -- working on tests

Collaborator

Salakar commented Nov 19, 2016

Closing as fixed on v3 branch.

Salakar closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment