Update gitversion #55
Conversation
paket.lock
Outdated
| @@ -878,4 +878,4 @@ GROUP Build | |||
| NUGET | |||
| remote: https://api.nuget.org/v3/index.json | |||
| FAKE (5.0.0-beta010) | |||
| GitVersion.CommandLine (3.6.5) | |||
| GitVersion.CommandLine (4.0.0-beta0012) | |||
There was a problem hiding this comment.
Is there something specific we need from the 4.0-pre chain? Why not stick with the stable release?
There was a problem hiding this comment.
there is GitTools/GitVersion#1043 which suggested the Gitversion error was already fixed. So I tried that. but then I had different error
build.fsx
Outdated
| let version = { gitVersion with BuildMetaData = Fake.EnvironmentHelper.environVar "TRAVIS_JOB_NUMBER" } | ||
| version | ||
| else | ||
| { gitVersion with BuildMetaData = "local" } |
There was a problem hiding this comment.
We can discuss whitespace all day long, and I don't have a strong enough preference to fight for it, but I do think that whitespace changes to big chunks of code like this should be isolated in its own PR, to make review of non-whitespace changes easier.
There was a problem hiding this comment.
As an aside, did you make these changes with some formatting tool? If so, which one, and with what settings?
If there's a standard tool to use, and it's possible to save its settings in a file and check it in, we should do that. Then, every developer can just use the formatting tool before submitting a PR, and the code will automatically be styled the same across the repo.
There was a problem hiding this comment.
It's common practice in F# to do 4 blanks. I did not plan to merge it here, just needed another diff to kick the CI
|
now we have "Could not find a 'develop' or 'master' branch, neither locally nor remotely." |
|
It's green ;-) |
No description provided.