Skip to content

Prefer IDisposable over IAsyncDisposable for disposing ReaderWriterLock #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abelbraaksma merged 1 commit into from
Dec 24, 2023
+2 −4
Merged

Prefer IDisposable over IAsyncDisposable for disposing ReaderWriterLock #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/FSharp.Control.TaskSeq/TaskSeqInternal.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,13 +978,11 @@ module internal TaskSeqInternal =
go <- step
}

interface IAsyncDisposable with
override _.DisposeAsync() =
interface IDisposable with
override _.Dispose() =
if not (isNull _rwLock) then
_rwLock.Dispose()

ValueTask.CompletedTask

let except itemsToExclude (source: TaskSeq<_>) =
checkNonNull (nameof source) source
checkNonNull (nameof itemsToExclude) itemsToExclude
Expand Down