-
Notifications
You must be signed in to change notification settings - Fork 8
Fix version number in docs and prepare new release #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
llucax
commented
Aug 16, 2023
- Clear release notes
- Fix outdated version in migrating and upgrading docs
- Clear release notes for release
- Bump version number in the docs
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
CI failing |
Signed-off-by: Leandro Lucarella <[email protected]>
Yeah, missed updating the tests. Should pass now. 🤞 |
Green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have an optional cosmetic comment and LGTM
- Fix adding of an empty keyword. | ||
|
||
- Don't distribute development files in the source distribution. | ||
- Fix outdated version number in the migrating and upgrading documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix outdated version number in the migrating and upgrading documentation. | |
- Fix outdated version number in migrating and upgrading documentation. |
I would have liked to accept those changes. If auto-merge is enabled and you make some comments, please either disable it or use the "request changes" type of comments to auto-merge is not triggered. |
To avoid another round for such a small change I will just fix it in the GitHub release description instead. |