Skip to content

Conversation

llucax
Copy link
Contributor

@llucax llucax commented Aug 16, 2023

  • Clear release notes
  • Fix outdated version in migrating and upgrading docs
  • Clear release notes for release
  • Bump version number in the docs

llucax added 3 commits August 16, 2023 13:45
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
@llucax llucax requested a review from a team as a code owner August 16, 2023 11:58
@llucax llucax requested a review from jack-herrmann August 16, 2023 11:58
@github-actions github-actions bot added the part:cookiecutter Affects the generation of projects using cookiecutter label Aug 16, 2023
@llucax llucax removed the request for review from jack-herrmann August 16, 2023 11:58
@llucax llucax assigned llucax and unassigned Marenz and daniel-zullo-frequenz Aug 16, 2023
@llucax llucax added this to the v0.5.1 milestone Aug 16, 2023
@llucax llucax added part:docs Affects the documentation type:bug Something isn't working labels Aug 16, 2023
@llucax llucax enabled auto-merge August 16, 2023 12:00
@Marenz
Copy link
Contributor

Marenz commented Aug 16, 2023

CI failing

Signed-off-by: Leandro Lucarella <[email protected]>
@github-actions github-actions bot added part:tests Affects the unit, integration and performance (benchmarks) tests and removed part:docs Affects the documentation part:cookiecutter Affects the generation of projects using cookiecutter labels Aug 16, 2023
@llucax
Copy link
Contributor Author

llucax commented Aug 16, 2023

Yeah, missed updating the tests. Should pass now. 🤞

@llucax
Copy link
Contributor Author

llucax commented Aug 16, 2023

Green

@llucax llucax added this pull request to the merge queue Aug 16, 2023
Copy link
Contributor

@daniel-zullo-frequenz daniel-zullo-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have an optional cosmetic comment and LGTM

- Fix adding of an empty keyword.

- Don't distribute development files in the source distribution.
- Fix outdated version number in the migrating and upgrading documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fix outdated version number in the migrating and upgrading documentation.
- Fix outdated version number in migrating and upgrading documentation.

Merged via the queue into frequenz-floss:v0.x.x with commit e0fbea7 Aug 16, 2023
@llucax llucax deleted the fix-version branch August 16, 2023 14:57
@llucax
Copy link
Contributor Author

llucax commented Aug 16, 2023

I only have an optional cosmetic comment and LGTM

I would have liked to accept those changes. If auto-merge is enabled and you make some comments, please either disable it or use the "request changes" type of comments to auto-merge is not triggered.

@llucax
Copy link
Contributor Author

llucax commented Aug 16, 2023

To avoid another round for such a small change I will just fix it in the GitHub release description instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:tests Affects the unit, integration and performance (benchmarks) tests type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants